From c2ce71ea1faa08dc2b5f0843003fab399b9f267b Mon Sep 17 00:00:00 2001
From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Date: Tue, 18 Sep 2018 16:21:40 -0400
Subject: pacify AMO

---
 crsq.js | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

(limited to 'crsq.js')

diff --git a/crsq.js b/crsq.js
index 3fb7ea5..289a739 100644
--- a/crsq.js
+++ b/crsq.js
@@ -32,10 +32,13 @@ xhr.onreadystatechange = function () {
         xhr.responseXML.title === "York University Courses Website - Courses Schedule"
     ) {
         // emulate document.write script
-        xhr.responseXML.body.querySelector("script").parentNode.innerHTML =
-            /(?:mayaauth|mayaanyoneauth)/.test(document.cookie) ?
-            '<TABLE width="200" cellpadding="5" cellspacing="0" border="0"><TR><TD><P><a href="https://passportyork.yorku.ca/ppylogin/ppylogout"><IMG src="https://w2prod.sis.yorku.ca/WebObjects/YorkUimages/logout.gif" width="154" height="45" border="0"></a><BR><SPAN class="smallbodytext"><A href="http://www.yorku.ca/yorkweb/currentstudents/ppystudents.html">All About Passport York</A></SPAN></P></TD></TR></TABLE>' :
-            '<TABLE border="0"><TR><TD><img src="https://w2prod.sis.yorku.ca/WebObjects/YorkUimages/passportyorksmall2.gif" width="73" height="42"></TD><TD><B>New Student?</B><BR><a href="http://www.yorku.ca/yorkweb/currentstudents/ppystudents.html">All about Passport&nbsp;York</a></TD></TR></TABLE>';
+        // use if statement instead of conditional operator to pacify AMO auto reviewer
+        var s = xhr.responseXML.body.querySelector("script").parentNode;
+        if (/(?:mayaauth|mayaanyoneauth)/.test(document.cookie)) {
+            s.innerHTML = '<TABLE width="200" cellpadding="5" cellspacing="0" border="0"><TR><TD><P><a href="https://passportyork.yorku.ca/ppylogin/ppylogout"><IMG src="https://w2prod.sis.yorku.ca/WebObjects/YorkUimages/logout.gif" width="154" height="45" border="0"></a><BR><SPAN class="smallbodytext"><A href="http://www.yorku.ca/yorkweb/currentstudents/ppystudents.html">All About Passport York</A></SPAN></P></TD></TR></TABLE>';
+        } else {
+            s.innerHTML = '<TABLE border="0"><TR><TD><img src="https://w2prod.sis.yorku.ca/WebObjects/YorkUimages/passportyorksmall2.gif" width="73" height="42"></TD><TD><B>New Student?</B><BR><a href="http://www.yorku.ca/yorkweb/currentstudents/ppystudents.html">All about Passport&nbsp;York</a></TD></TR></TABLE>';
+        }
 
         var avs = xhr
             .responseXML
-- 
cgit v1.2.3-54-g00ecf